-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Uuids #132
Support Uuids #132
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't believe I missed this PR, my apologies. This is a great change. @shaopeng-gh, can you follow up on this merge with some tests that follow the current pattern (for the GUID type)? In reply to: 1235685004 |
Thank you! In reply to: 1235806019 |
Yes, looking. In reply to: 1235685004 |
Co-authored-by: thefringeninja <[email protected]>
@thefringeninja please review and approve my pull request against your branch: In reply to: 1237512812 |
FEATURE: Add support for JSON Schema type `uuid` - test
@michaelcfanning I have fixed the test in his branch, please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.